andrei/starship
1
0
Fork 0
mirror of https://github.com/starship/starship.git synced 2026-06-24 02:01:36 +07:00
Code Issues Packages Projects Releases 10 Wiki Activity

perf(crystal): Lazily evaluate version command (#2129)

Browse Source 
* perf(crystal): Lazily evaluate version command

This updates the module to lazily execute the `crystal --version`
command only when the `version` variable is used in the format string.

* perf(crystal): Update format string

Update format string to handle the `$version` variable not being set.
This commit is contained in:
Thomas O'Donnell
2021-01-13 18:35:44 +01:00
committed by GitHub
parent d49ff412f6
commit f640db87a4
3 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/crystal.rs
+6 -5
View File
@@ -20,8 +20,6 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
return None;
}
let crystal_version = utils::exec_cmd("crystal", &["--version"])?.stdout;
let mut module = context.new_module("crystal");
let config: CrystalConfig = CrystalConfig::try_load(module.config);
@@ -36,7 +34,10 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
_ => None,
})
.map(|variable| match variable {
"version" => format_crystal_version(&crystal_version).map(Ok),
"version" => format_crystal_version(
utils::exec_cmd("crystal", &["--version"])?.stdout.as_str(),
)
.map(Ok),
_ => None,
})
.parse(None)
@@ -89,7 +90,7 @@ mod tests {
File::create(dir.path().join("shard.yml"))?.sync_all()?;
let actual = ModuleRenderer::new("crystal").path(dir.path()).collect();
let expected = Some(format!("via {} ", Color::Red.bold().paint("🔮 v0.35.1")));
let expected = Some(format!("via {}", Color::Red.bold().paint("🔮 v0.35.1 ")));
assert_eq!(expected, actual);
dir.close()
@@ -101,7 +102,7 @@ mod tests {
File::create(dir.path().join("main.cr"))?.sync_all()?;
let actual = ModuleRenderer::new("crystal").path(dir.path()).collect();
let expected = Some(format!("via {} ", Color::Red.bold().paint("🔮 v0.35.1")));
let expected = Some(format!("via {}", Color::Red.bold().paint("🔮 v0.35.1 ")));
assert_eq!(expected, actual);
dir.close()