andrei/starship
1
0
Fork 0
mirror of https://github.com/starship/starship.git synced 2026-06-23 02:05:51 +07:00
Code Issues Packages Projects Releases 10 Wiki Activity

perf(php): Lazy eval php (#2190)

Browse Source 
* perf(php): evaluate version lazily

* fix(php): update format string; update tests

Co-authored-by: Moritz Vetter <mv@3yourmind.com>
This commit is contained in:
Moritz Vetter
2021-01-22 18:03:18 +01:00
committed by GitHub
parent 60be1e9540
commit d10a83ce6b
3 changed files with 47 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/config/README.md
+2 -2
View File
@@ -1965,8 +1965,8 @@ The module will be shown if any of the following conditions are met:
### Options ### Options
| Option | Default | Description | | Option | Default | Description |
| ---------- | ---------------------------------- | ----------------------------------------------------- | | ---------- | ------------------------------------ | ----------------------------------------------------- |
| `format` | `"via [$symbol$version]($style) "` | The format for the module. | | `format` | `"via [$symbol($version )]($style)"` | The format for the module. |
| `symbol` | `"🐘 "` | The symbol used before displaying the version of PHP. | | `symbol` | `"🐘 "` | The symbol used before displaying the version of PHP. |
| `style` | `"147 bold"` | The style for the module. | | `style` | `"147 bold"` | The style for the module. |
| `disabled` | `false` | Disables the `php` module. | | `disabled` | `false` | Disables the `php` module. |
src/configs/php.rs
+1 -1
View File
@@ -15,7 +15,7 @@ impl<'a> RootModuleConfig<'a> for PhpConfig<'a> {
PhpConfig { PhpConfig {
symbol: "🐘 ", symbol: "🐘 ",
style: "147 bold", style: "147 bold",
format: "via [$symbol$version]($style) ", format: "via [$symbol($version )]($style)",
disabled: false, disabled: false,
} }
} }
src/modules/php.rs
+16 -18
View File
@@ -20,14 +20,6 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
return None; return None;
} }
match utils::exec_cmd(
"php",
&[
"-nr",
"echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;",
],
) {
Some(php_cmd_output) => {
let mut module = context.new_module("php"); let mut module = context.new_module("php");
let config: PhpConfig = PhpConfig::try_load(module.config); let config: PhpConfig = PhpConfig::try_load(module.config);
@@ -42,7 +34,16 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
_ => None, _ => None,
}) })
.map(|variable| match variable { .map(|variable| match variable {
"version" => Some(Ok(format_php_version(&php_cmd_output.stdout))), "version" => {
let php_cmd_output = utils::exec_cmd(
"php",
&[
"-nr",
"echo PHP_MAJOR_VERSION.\".\".PHP_MINOR_VERSION.\".\".PHP_RELEASE_VERSION;",
],
)?;
Some(Ok(format_php_version(&php_cmd_output.stdout)))
}
_ => None, _ => None,
}) })
.parse(None) .parse(None)
@@ -57,9 +58,6 @@ pub fn module<'a>(context: &'a Context) -> Option<Module<'a>> {
}); });
Some(module) Some(module)
}
None => None,
}
} }
fn format_php_version(php_version: &str) -> String { fn format_php_version(php_version: &str) -> String {
@@ -99,8 +97,8 @@ mod tests {
let actual = ModuleRenderer::new("php").path(dir.path()).collect(); let actual = ModuleRenderer::new("php").path(dir.path()).collect();
let expected = Some(format!( let expected = Some(format!(
"via {} ", "via {}",
Color::Fixed(147).bold().paint("🐘 v7.3.8") Color::Fixed(147).bold().paint("🐘 v7.3.8 ")
)); ));
assert_eq!(expected, actual); assert_eq!(expected, actual);
dir.close() dir.close()
@@ -114,8 +112,8 @@ mod tests {
let actual = ModuleRenderer::new("php").path(dir.path()).collect(); let actual = ModuleRenderer::new("php").path(dir.path()).collect();
let expected = Some(format!( let expected = Some(format!(
"via {} ", "via {}",
Color::Fixed(147).bold().paint("🐘 v7.3.8") Color::Fixed(147).bold().paint("🐘 v7.3.8 ")
)); ));
assert_eq!(expected, actual); assert_eq!(expected, actual);
dir.close() dir.close()
@@ -129,8 +127,8 @@ mod tests {
let actual = ModuleRenderer::new("php").path(dir.path()).collect(); let actual = ModuleRenderer::new("php").path(dir.path()).collect();
let expected = Some(format!( let expected = Some(format!(
"via {} ", "via {}",
Color::Fixed(147).bold().paint("🐘 v7.3.8") Color::Fixed(147).bold().paint("🐘 v7.3.8 ")
)); ));
assert_eq!(expected, actual); assert_eq!(expected, actual);
dir.close() dir.close()