andrei/niri
1
0
Fork 0
mirror of https://github.com/niri-wm/niri.git synced 2026-06-23 02:05:33 +07:00
Code Issues Packages Projects Releases 10 Wiki Activity

Somewhat fix height distribution logic

Browse Source 
This got a bit broken with fractional layout. The current logic seems to
give exact results for integer scales again, but for fractional scales
sometimes the resulting height goes beyond the maximum, even clearly by
more than one logical pixel. Not entirely sure why that is.
This commit is contained in:
Ivan Molodetskikh
2024-06-19 08:46:01 +03:00
parent 39632e9c1e
commit c0ded35783
1 changed files with 24 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/layout/workspace.rs
+24 -28
View File
@@ -2997,7 +2997,7 @@ impl<W: LayoutElement> Column<W> {
.map(|(tile, data)| match data.height { .map(|(tile, data)| match data.height {
WindowHeight::Auto => WindowHeight::Auto, WindowHeight::Auto => WindowHeight::Auto,
WindowHeight::Fixed(height) => { WindowHeight::Fixed(height) => {
WindowHeight::Fixed(tile.tile_height_for_window_height(height)) WindowHeight::Fixed(tile.tile_height_for_window_height(height.round().max(1.)))
} }
}) })
.collect::<Vec<_>>(); .collect::<Vec<_>>();
@@ -3018,7 +3018,6 @@ impl<W: LayoutElement> Column<W> {
if min_size.h > 0. { if min_size.h > 0. {
*h = f64::max(*h, min_size.h); *h = f64::max(*h, min_size.h);
} }
*h = f64::max(*h, 1.);
height_left -= *h + self.options.gaps; height_left -= *h + self.options.gaps;
auto_tiles_left -= 1; auto_tiles_left -= 1;
@@ -3037,37 +3036,33 @@ impl<W: LayoutElement> Column<W> {
// However, most max height uses are for fixed-size dialogs, where min height == max_height. // However, most max height uses are for fixed-size dialogs, where min height == max_height.
// This case is separately handled above. // This case is separately handled above.
while auto_tiles_left > 0 { while auto_tiles_left > 0 {
// Compute the current auto height. // Wayland requires us to round the requested size for a window to integer logical
let auto_height = height_left / auto_tiles_left as f64 - self.options.gaps; // pixels, therefore we compute the remaining auto height dynamically.
let auto_height = f64::max(auto_height, 1.); let mut height_left_2 = height_left;
let mut auto_tiles_left_2 = auto_tiles_left;
// Integer division above can result in imperfect height distribution. We will make some
// tiles 1 px taller to account for this.
let mut ones_left = f64::max(
0.,
height_left - (auto_height + self.options.gaps) * auto_tiles_left as f64,
) as i32;
let mut unsatisfied_min = false; let mut unsatisfied_min = false;
let mut ones_left_2 = ones_left; for ((h, tile), min_size) in zip(zip(&mut heights, &self.tiles), &min_size) {
for (h, min_size) in zip(&mut heights, &min_size) {
if matches!(h, WindowHeight::Fixed(_)) { if matches!(h, WindowHeight::Fixed(_)) {
continue; continue;
} }
let mut auto = auto_height; // Compute the current auto height.
if ones_left_2 > 0 { let auto = height_left_2 / auto_tiles_left_2 as f64 - self.options.gaps;
auto += 1.; let mut auto = tile.tile_height_for_window_height(
ones_left_2 -= 1; tile.window_height_for_tile_height(auto).round().max(1.),
} );
// Check if the auto height satisfies the min height. // Check if the auto height satisfies the min height.
if min_size.h > 0. && min_size.h > auto { if min_size.h > 0. && min_size.h > auto {
*h = WindowHeight::Fixed(min_size.h); auto = min_size.h;
height_left -= min_size.h + self.options.gaps; *h = WindowHeight::Fixed(auto);
height_left -= auto + self.options.gaps;
auto_tiles_left -= 1; auto_tiles_left -= 1;
unsatisfied_min = true; unsatisfied_min = true;
} }
height_left_2 -= auto + self.options.gaps;
auto_tiles_left_2 -= 1;
} }
// If some min height was unsatisfied, then we allocated the tile more than the auto // If some min height was unsatisfied, then we allocated the tile more than the auto
@@ -3078,18 +3073,19 @@ impl<W: LayoutElement> Column<W> {
} }
// All min heights were satisfied, fill them in. // All min heights were satisfied, fill them in.
for h in &mut heights { for (h, tile) in zip(&mut heights, &self.tiles) {
if matches!(h, WindowHeight::Fixed(_)) { if matches!(h, WindowHeight::Fixed(_)) {
continue; continue;
} }
let mut auto = auto_height; // Compute the current auto height.
if ones_left > 0 { let auto = height_left / auto_tiles_left as f64 - self.options.gaps;
auto += 1.; let auto = tile.tile_height_for_window_height(
ones_left -= 1; tile.window_height_for_tile_height(auto).round().max(1.),
} );
*h = WindowHeight::Fixed(auto); *h = WindowHeight::Fixed(auto);
height_left -= auto + self.options.gaps;
auto_tiles_left -= 1; auto_tiles_left -= 1;
} }