andrei/amnezia-client
1
0
Fork 0
mirror of https://github.com/amnezia-vpn/amnezia-client.git synced 2026-06-23 02:00:20 +07:00
Code Issues Packages Projects Releases 10 Wiki Activity

ISSUE: Service is crashed after disconnecting

Browse Source 
ROOT CAUSE: When disconnecting service, m_logworker is deleted in thread which does not have affinity with m_logworker.
			The time m_logworker is deleted, it may be used by m_logthread and make the service crashed

ACTION: Connect signal finished() of m_logthread to deleteLater() slot of m_logworker to safety delete it.
This commit is contained in:
Dan Nguyen
2024-03-17 07:09:57 +07:00
parent 9f82b4c21f
commit b7c513c05f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/platforms/windows/daemon/windowstunnelservice.cpp
+1 -1
View File
@@ -58,7 +58,6 @@ void WindowsTunnelService::stop() {
if (m_logworker) { if (m_logworker) {
m_logthread.quit(); m_logthread.quit();
m_logthread.wait(); m_logthread.wait();
delete m_logworker;
m_logworker = nullptr; m_logworker = nullptr;
} }
} }
@@ -104,6 +103,7 @@ bool WindowsTunnelService::start(const QString& configData) {
m_logworker = new WindowsTunnelLogger(WindowsCommons::tunnelLogFile()); m_logworker = new WindowsTunnelLogger(WindowsCommons::tunnelLogFile());
m_logworker->moveToThread(&m_logthread); m_logworker->moveToThread(&m_logthread);
connect(&m_logthread, &QThread::finished, m_logworker, &QObject::deleteLater);
m_logthread.start(); m_logthread.start();
SC_HANDLE scm = (SC_HANDLE)m_scm; SC_HANDLE scm = (SC_HANDLE)m_scm;